Skip to content
Jump to bottom

Update libxslt from 1.1.29 to 1.1.32 #641

Merged
merged 5 commits into from
Feb 26, 2018
Merged

Update libxslt from 1.1.29 to 1.1.32 #641

merged 5 commits into from
Feb 26, 2018

Conversation

donald
Copy link
Collaborator

@donald donald commented Feb 25, 2018

After the glibc update, libxslt needs a rebulild
I require it to rebuild perl-5.26.1

@donald
libxslt: Remove unneeded source lines
352989c
@donald
libxslt: Recreate with current template
7c851c1
@donald
libxslt: Convert to versionless bee file
1f19103
@donald
libxslt: Upgrade from version 1.1.29 to 1.1.32
6790255 
We need to rebuild libxslt after the glibc update. Otherwise
applications can no longer build against this library:

    cc -c  -I/usr/include/libxml2 -I/usr/include/libxml2   -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2 -O2   -DVERSION=\"1.96\" -DXS_VERSION=\"1.96\" -fPIC "-I/dev/shm/perl-5.26.1-4/lib/5.26.1/x86_64-linux/CORE"  -DHAVE_BLANK -DHAVE_BLANK -DHAVE_EXSLT LibXSLT.c
    In file included from /usr/include/libxslt/xsltInternals.h:24:0,
                     from LibXSLT.xs:14:
    /usr/include/libxslt/xsltlocale.h:20:10: fatal error: xlocale.h: No such file or directory
     #include <xlocale.h>
              ^~~~~~~~~~~
    compilation terminated.

xlocale.h was dropped from the newer glibc releases.

When we rebuild anyway, we upgrade to latest available version.
@donald
libxslt: Remove python bindings
e3412ea 
Because we are going to remove the system python, remove the python
bindings.
@thomas
Copy link
Collaborator

thomas commented Feb 25, 2018 via email

@donald
Copy link
Collaborator Author

donald commented Feb 25, 2018

Because glibc removed xlocale.h in 1.26.

https://sourceware.org/ml/libc-alpha/2017-08/msg00010.html:

* The nonstandard header <xlocale.h> has been removed.  Most programs should
  use <locale.h> instead.  If you have a specific need for the definition of
  locale_t with no other declarations, please contact
  libc-alpha@sourceware.org and explain.

https://sourceware.org/glibc/wiki/Release/2.26#Removal_of_.27xlocale.h.27:

4.1. Removal of 'xlocale.h'

The nonstandard header xlocale.h has been removed in this release. It was never intended
to be included directly by programs other than glibc itself, and it was a strict subset of the standard
header locale.h. We know that a number of programs do include it, but because it has never been
part of any other C library, programs that use it are probably testing for its existence with autoconf
or a similar tool, and should not fail to compile.

Packagers need to watch out for cases where a library installs headers that assume xlocale.h is
available. Programs that use those headers will fail to build after glibc is updated to 2.26. This is
known to be an issue for Perl extension modules (see Red Hat bug 1464244); Perl checks for
xlocale.h when it is built, so this particular case can be resolved by rebuilding Perl against glibc 2.26.

Didn't stumble on libxml issues (yet).

@thomas thomas merged commit e8b69f1 into master Feb 26, 2018
@donald donald deleted the update-libxslt-from-1.1.29-to-1.1.32 branch February 26, 2018 15:12
Sign in to join this conversation on GitHub.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@donald @thomas